dials for 'ordinal_reg' models#435
Merged
hfrick merged 17 commits intotidymodels:mainfrom Mar 5, 2026
Merged
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two dials for the
ordinal_reg()model (see this companion PR to parsnip):ordinal_linkandodds_link. Together they form a composite link function for ordinal regression models. The PR also adds a minimal set of unit tests for them.A third dial to control the parallel regression assumption is speculated here. However, since this is in preparation for a limited first release of the {ordered} extension, i suggest having a longer discussion with specialist and user feedback before introducing it.
A note about the commit history: I defined several additional dials for engine-specific rather than model-specific parameters before grasping this difference; see this thread.
(There is no open issue corresponding to this PR.)