Skip to content

Conversation

topepo
Copy link
Member

@topepo topepo commented Sep 13, 2024

From tidymodels/parsnip#1191

After this PR, we will add a remote to parsnip for this version, then remove the redundant functions.

@topepo topepo marked this pull request as ready for review September 13, 2024 16:28
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I review, since this is easier for you to affirm verbally than for me to tell via diffs: are there differences in the implementation proposed here vs. the one just merged into parsnip?

@topepo
Copy link
Member Author

topepo commented Sep 13, 2024

The only difference that I can think of is that I had to import as_tibble() to get the S3 dispatch for that to work.

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@hfrick hfrick merged commit 278633a into main Sep 23, 2024
11 checks passed
@hfrick hfrick deleted the quantile-pred branch September 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants