Skip to content

Conversation

EmilHvitfeldt
Copy link
Member

Ref: #1125

Tried to follow how we documented case weights usage across models/engines.

?sparse_data doesn't really say a lot, but it also doesn't really need to because parsnip should just work if the engine allows it

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, this is a nice addition.

Note to self that I ought to make sure passing sparse data works in bonsai with LightGBM. Let me know if you have any notes to keep in mind there.

@EmilHvitfeldt EmilHvitfeldt merged commit cee2bb8 into main Sep 9, 2024
10 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the doc-sparse-data branch September 9, 2024 19:26
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants