Make sure all sparse data errors look nice #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
reviewed
Sep 5, 2024
| @@ -1,5 +1,5 @@ | |||
| to_sparse_data_frame <- function(x, object) { | |||
| if (methods::is(x, "sparseMatrix")) { | |||
There was a problem hiding this comment.
Digging this refactor. :)
simonpcouch
approved these changes
Sep 6, 2024
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1125
This PR does two things.
First it adds an error if you try to use a sparse matrix with
fit(), that redirects the user to usefit_xy().Second, it passes the
callargument throughto_sparse_data_frame()for nicer errors.