Skip to content

Conversation

topepo
Copy link
Member

@topepo topepo commented Oct 21, 2024

Mostly data descriptors and outcome checking.

The PR also removes a few redundant tests of fit.model_spec() that probably came about form me copy/pasting in the early days.

@topepo topepo requested a review from simonpcouch October 21, 2024 15:22
@topepo topepo marked this pull request as ready for review October 21, 2024 15:22
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

topepo and others added 3 commits October 21, 2024 13:53
@topepo topepo merged commit 33f621c into main Oct 21, 2024
10 checks passed
@topepo topepo deleted the rlang-to-cli branch October 21, 2024 18:56
@github-actions
Copy link

github-actions bot commented Nov 5, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants