Switch from GPfit to GauPro for Gaussian Processes #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
commented
Oct 17, 2025
| @@ -1,4 +1,17 @@ | |||
| library(tidymodels) | |||
| library(broom) | |||
There was a problem hiding this comment.
Note: we were getting warnings with the old tests that:
namespace 'workflowsets' is not available and has been replaced
Not loading tidymodels solves this and it comes up in the tests for #1007 1007
EmilHvitfeldt
approved these changes
Oct 18, 2025
Comment on lines
-247
to
-248
| "There are {cli::qty(diff)}{?as many/more} tuning parameters | ||
| {cli::qty(diff)}{?as/than} there are initial points. |
There was a problem hiding this comment.
Why are these lines being deleted?
if that is intentional then we also don't need cli::pluralize()
| dplyr::filter(.metric == metrics) |> | ||
| dplyr::filter(!is.na(mean)) | ||
|
|
||
| # TODO a lot of slice_min/slice_max can be used now |
There was a problem hiding this comment.
Should add as an issue if you are not planning on dealing with it in this PR.
| } | ||
|
|
||
| withr::with_seed( | ||
| 114, |
There was a problem hiding this comment.
why are we hardcoding this specific seed?
Co-authored-by: Emil Hvitfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPfit maintainer contacted me a few months ago about the potential for that package to fall off CRAN. This change helps from a sustainability point of view, but also adds some new features.
I've tested this extensively on the analyses in aml4td and TMwR and get very similar results.