Draft
Conversation
8019728 to
5f9a74a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first push to have tidyclust leverage the new tuning infrastructure.
This PR is very much just a DRAFT. I know that there are things that needs to be sorted out, and cleaned up. But it acts a starting point, and as an initial gauge of the amount of changes would be required
Note on Parameter Registries
parsnip::get_from_env()which queries parsnip's internal environmentget_param_info()handles NULL gracefully, defaultinghas_submodel = FALSEalternative solution is to import modelenv and have it swap between them depending on the model type. Also worth noting that tidyclust doesn't have any models that use the submodel trick.
This means tidyclust models won't benefit from submodel optimization (multipredict), but this is a minor performance consideration.