Conversation
maelle
commented
Feb 6, 2025
maelle
commented
- add missing elements
- add reference to other vignettes at the relevant places instead of at the end.
|
|
||
| The duckplyr package aims at providing a fully compatible drop-in replacement for dplyr. | ||
| To achieve this, only a carefully selected subset of dplyr's operations, R functions, and R data types are implemented. | ||
| Currently, only a carefully selected subset of dplyr's operations, R functions, and R data types are implemented (see `vignette("limits")`). |
There was a problem hiding this comment.
it is confusing to say you achieve a fully compatible drop-in by carefully selecting a subset of features to implement.
There was a problem hiding this comment.
Is that still the case with the current wording?
There was a problem hiding this comment.
It could still be rephrased then. But I used "currently" to mean that later this could change.
|
Need to review with |
|
Split into two commits. |
|
Interesting. I'm avoiding too many references to other articles inside the text because I want the reader to stay with me and not jump around. That's why I strive to make the articles as short as possible. I also see how it's convenient to mention "in place". TBD. |
krlmlr
force-pushed
the
fallbacks
branch
2 times, most recently
from
c7ec8af to
42ce6ad
Compare
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Thanks. Keeping this open for discussion, but I think I took what I wanted to take from here.
|
|
||
| The duckplyr package aims at providing a fully compatible drop-in replacement for dplyr. | ||
| To achieve this, only a carefully selected subset of dplyr's operations, R functions, and R data types are implemented. | ||
| Currently, only a carefully selected subset of dplyr's operations, R functions, and R data types are implemented (see `vignette("limits")`). |
There was a problem hiding this comment.
Is that still the case with the current wording?
| ``` | ||
|
|
||
| The plan shows three operations: | ||
| The plan shows three **operations**: |
There was a problem hiding this comment.
At most one per article, please, and really only if necessary 📣
There was a problem hiding this comment.
Hehe I'll keep the bold for the R-hub blog for instance then. I find it easier for skimming (reading once, then skimming to remind myself of important points) compared to italic. 😇
| The `last_rel()` function now shows a relation that describes logical plan for executing the whole pipeline. | ||
|
|
||
| ## Functionality not supported by DuckDB | ||
| ## A pipeline with functionality not directly supported by duckplyr |
There was a problem hiding this comment.
How about "Outsourcing to dplyr"?
|
@copilot: Resolve conflicts. |
