Skip to content

feat!: Do not overwrite on attaching #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −26
Open

feat!: Do not overwrite on attaching #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions R/zzz.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,6 @@ on_load({
run_on_load()
}

.onAttach <- function(lib, pkg) {
if (!exists(".__DEVTOOLS__", asNamespace("duckplyr"))) {
msg <- character()
suppressMessages(try_fetch(methods_overwrite(), message = function(cond) {
msg <<- c(msg, conditionMessage(cond))
zap()
}))
packageStartupMessage(msg)
}
}

.onDetach <- function(lib) {
if (!exists(".__DEVTOOLS__", asNamespace("duckplyr"))) {
msg <- character()
suppressMessages(try_fetch(methods_restore(), message = function(cond) {
msg <<- c(msg, conditionMessage(cond))
zap()
}))
packageStartupMessage(msg)
}
}

# Avoid R CMD check warning
dummy <- function() {
memoise::memoise()
Expand Down
7 changes: 3 additions & 4 deletions vignettes/developers.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ conflict_prefer("filter", "dplyr")

## Introduction

The default behavior of duckplyr is to enable itself for all data frames in the session.
This happens when the package is attached with `library(duckplyr)`, or by calling `methods_overwrite()`.
To enable duckplyr for individual data frames instead of session-wide, it is sufficient to prefix all calls to duckplyr functions with `duckplyr::` and not attach the package.
Alternatively, `methods_restore()` can be called to undo the session-wide overwrite after `library(duckplyr)`.
As of duckplyr 1.2.0, duckplyr will no longer automatically override dplyr methods for all data frames in the session when the package is attached with `library(duckplyr)`.
This change makes it easier to use duckplyr alongside dplyr and other packages that depend on dplyr.
You can still enable duckplyr for all data frames in the session by calling `methods_overwrite()` after attaching the package, and undo the session-wide overwrite using `methods_restore()`.

## External data with explicit qualification

Expand Down
Loading