Skip to content

feat: Avoid strict checks in R, rely on duckdb #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Avoid strict checks in R, rely on duckdb #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions R/relational-duckdb.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ check_df_for_rel <- function(df, call = caller_env()) {

# FIXME: For some other reason, it seems crucial to assign the result to a
# variable before returning it
out <- duckdb$rel_from_df(con, df)
out <- duckdb$rel_from_df(con, df, strict = TRUE)

roundtrip <- duckdb$rapi_rel_to_altrep(out)
if (Sys.getenv("DUCKPLYR_CHECK_ROUNDTRIP") == "TRUE") {
Expand All @@ -188,14 +188,6 @@ check_df_for_rel <- function(df, call = caller_env()) {
}
}
})
} else {
for (i in seq_along(df)) {
df_attrib <- attributes(df[[i]])
roundtrip_attrib <- attributes(roundtrip[[i]])
if (!identical(df_attrib, roundtrip_attrib)) {
cli::cli_abort("Attributes are lost during conversion. Affected column: {.var {names(df)[[i]]}}.", call = call)
}
}
}

out
Expand Down
Loading