Skip to content

Only call zero_range() and as.numeric() in transformed space #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Only call zero_range() and as.numeric() in transformed space #5304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30f2726
Only call `zero_range()` and `as.numeric()` in transformed space
DavisVaughan May 10, 2023
1cf04d0
Add comment with link to PR
DavisVaughan May 10, 2023
3cfb20e
NEWS bullet
DavisVaughan May 10, 2023
a9d87dc
Merge branch 'main' into fix/zero-range-transformed-scale
teunbrand Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* `ScaleContinuous$get_breaks()` now only calls `scales::zero_range()` on limits
in transformed space, rather than in data space (#5304).

* Scales throw more informative messages (@teunbrand, #4185, #4258)

* The `scale_name` argument in `continuous_scale()`, `discrete_scale()` and
Expand Down
4 changes: 3 additions & 1 deletion R/scale-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,9 @@ ScaleContinuous <- ggproto("ScaleContinuous", Scale,
)
}

if (zero_range(as.numeric(limits))) {
# Compute `zero_range()` in transformed space in case `limits` in data space
# don't support conversion to numeric (#5304)
if (zero_range(as.numeric(self$trans$transform(limits)))) {
breaks <- limits[1]
} else if (is.waive(self$breaks)) {
if (!is.null(self$n.breaks) && trans_support_nbreaks(self$trans)) {
Expand Down