Skip to content

Fix regression theme(legend.direction) #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix regression theme(legend.direction) #5508

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f2f8fa
use correct direction
teunbrand Nov 3, 2023
98d7827
Add test
teunbrand Nov 3, 2023
d8d4eae
Merge branch 'main' into legend_direction
teunbrand Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/guides-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ Guides <- ggproto(
horizontal = c("center", "top")
)

grobs <- self$draw(theme, position, default_direction)
grobs <- self$draw(theme, position, theme$legend.direction)
if (length(grobs) < 1) {
return(zeroGrob())
}
Expand Down
115 changes: 115 additions & 0 deletions tests/testthat/_snaps/guides/horizontal-legend-direction.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading