Skip to content

Enable horizontal margins on (sub)title/caption #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Enable horizontal margins on (sub)title/caption #5545

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
442c457
enable x-margins
teunbrand Nov 29, 2023
188fc3b
add news bullet
teunbrand Nov 29, 2023
a6daac2
Merge branch 'main' into full_margins
teunbrand Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* The plot's title, subtitle and caption now obey horizontal text margins
(#5533).

* Lines where `linewidth = NA` are now dropped in `geom_sf()` (#5204).

* New `guide_axis_logticks()` can be used to draw logarithmic tick marks as
Expand Down
15 changes: 12 additions & 3 deletions R/plot-build.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,15 +265,24 @@ ggplot_gtable.ggplot_built <- function(data) {
}

# Title
title <- element_render(theme, "plot.title", plot$labels$title, margin_y = TRUE)
title <- element_render(
theme, "plot.title", plot$labels$title,
margin_y = TRUE, margin_x = TRUE
)
title_height <- grobHeight(title)

# Subtitle
subtitle <- element_render(theme, "plot.subtitle", plot$labels$subtitle, margin_y = TRUE)
subtitle <- element_render(
theme, "plot.subtitle", plot$labels$subtitle,
margin_y = TRUE, margin_x = TRUE
)
subtitle_height <- grobHeight(subtitle)

# whole plot annotation
caption <- element_render(theme, "plot.caption", plot$labels$caption, margin_y = TRUE)
caption <- element_render(
theme, "plot.caption", plot$labels$caption,
margin_y = TRUE, margin_x = TRUE
)
caption_height <- grobHeight(caption)

# positioning of title and subtitle is governed by plot.title.position
Expand Down