Skip to content

check_device(): Early exit for null device #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

check_device(): Early exit for null device #5567

merged 1 commit into from
Dec 8, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR aims to implement #5299 (comment).

Briefly, if there is no device open, the 'device' is the null device. When that is the device name, maybe is returned early.

@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Dec 7, 2023
@teunbrand teunbrand requested a review from thomasp85 December 7, 2023 10:12
thomasp85
thomasp85 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand
Copy link
Collaborator Author

Thanks!

@teunbrand teunbrand merged commit 70a4c0e into tidyverse:main Dec 8, 2023
@teunbrand teunbrand deleted the check_device_early_exit branch December 8, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@teunbrand @thomasp85