Improve pal_qualitative()
#5954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Jun 21, 2024
| @@ -1,6 +1,5 @@ | |||
| test_that("scale_hue() checks the type input", { | |||
| pal <- pal_qualitative(type = 1:4) | |||
| expect_snapshot_error(pal(4)) | |||
| expect_snapshot_error(pal_qualitative(type = 1:4)) | |||
There was a problem hiding this comment.
error is now thrown in palette factory rather than the output function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5013.
Briefly, it implements the fix proposed here and polishes
pal_qualitative()a little bit.Tangentially related, shouldn't
pal_qualitative()be a function in {scales}?