Move {MASS} to Suggests #5993
Merged
Move {MASS} to Suggests #5993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MASS is now dependent on R4.4, stopping me from installing ggplot2 (as a dep) on my friendly local cluster which tops out at R4.3. So, what's the status of this PR? 👼 |
|
ggplot2's requirement is not that strict on the version of MASS, so it's not really a big deal in theory, while it feels tricky. You should be able to install some older version of MASS like this. remotes::install_version("MASS", "7.3-60.0.1") |
This reverts commit 93295f5.
Merge branch 'main' into mass_to_suggests # Conflicts: # DESCRIPTION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix part of #5986 (comment).
Briefly, MASS is required for 2D KDE and a particular ellipse type and not broadly all over ggplot2.
This PR moves it to Suggests, adds checks whether it is installed in the relevant places and skips tests when it is not installed.