Skip to content

check type for date_breaks and date_minor_breaks #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2024
Merged

check type for date_breaks and date_minor_breaks #6044

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b53b2d0
check type for date_breaks and date_minor_breaks #5880
RodDalBen Aug 15, 2024
fd5a831
`date_labels` should be string too
teunbrand Sep 10, 2024
c518dee
add tests
teunbrand Sep 10, 2024
2cef6bb
add news bullet
teunbrand Sep 10, 2024
832a0ea
Merge branch 'main' into type-date_breaks
teunbrand Sep 10, 2024
1c88482
resolve merge conflict + use snapshots
teunbrand Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/scale-date.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,11 @@ datetime_scale <- function(aesthetics, transform, trans = deprecated(),
if (is.character(minor_breaks)) minor_breaks <- breaks_width(minor_breaks)

if (!is.waive(date_breaks)) {
check_string(date_breaks)
breaks <- breaks_width(date_breaks)
}
if (!is.waive(date_minor_breaks)) {
check_string(date_minor_breaks)
minor_breaks <- breaks_width(date_minor_breaks)
}
if (!is.waive(date_labels)) {
Expand Down