Skip to content

No ticks no space #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2024
Merged

No ticks no space #6071

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8c96d8
no space for blank ticks
teunbrand Sep 2, 2024
6c136a1
preserve axis text spacing for `theme_minimal()`
teunbrand Sep 3, 2024
895d5b2
add news bullet
teunbrand Sep 3, 2024
21afc10
Merge branch 'main' into no_ticks_no_space
teunbrand Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# ggplot2 (development version)

* `guide_axis()` no longer reserves space for blank ticks
(@teunbrand, #4722, #6069).
* `guide_bins()`, `guide_colourbar()` and `guide_coloursteps()` gain an `angle`
argument to overrule theme settings, similar to `guide_axis(angle)`
(@teunbrand, #4594).
Expand Down
6 changes: 6 additions & 0 deletions R/guide-axis.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,12 @@ GuideAxis <- ggproto(
override_elements = function(params, elements, theme) {
elements$text <-
label_angle_heuristic(elements$text, params$position, params$angle)
if (inherits(elements$ticks, "element_blank")) {
elements$major_length <- unit(0, "cm")
}
if (inherits(elements$minor, "element_blank") || isFALSE(params$minor.ticks)) {
elements$minor_length <- unit(0, "cm")
}
return(elements)
},

Expand Down
6 changes: 5 additions & 1 deletion R/theme-defaults.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,11 @@ theme_minimal <- function(base_size = 11, base_family = "",
base_rect_size = base_rect_size
) %+replace%
theme(
axis.ticks = element_blank(),
axis.ticks = element_blank(), # Extra margins due to absence ticks
axis.text.x.bottom = element_text(margin = margin(t = 0.45 * base_size)),
axis.text.x.top = element_text(margin = margin(b = 0.45 * base_size)),
axis.text.y.left = element_text(margin = margin(r = 0.45 * base_size)),
axis.text.y.right = element_text(margin = margin(l = 0.45 * base_size)),
legend.background = element_blank(),
legend.key = element_blank(),
panel.background = element_blank(),
Expand Down