Skip to content

Fix regression from #6027 #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix regression from #6027 #6098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b64ce
fallback for numeric expand
teunbrand Sep 11, 2024
31277ea
add test
teunbrand Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions R/coord-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,9 @@ render_axis <- function(panel_params, axis, scale, position, theme) {

# Elaborates an 'expand' argument for every side (top, right, bottom or left)
parse_coord_expand <- function(expand) {
if (is.numeric(expand) && all(expand %in% c(0, 1))) {
expand <- as.logical(expand)
}
check_logical(expand)
if (anyNA(expand)) {
cli::cli_abort("{.arg expand} cannot contain missing values.")
Expand Down
17 changes: 17 additions & 0 deletions tests/testthat/test-coord-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,23 @@ test_that("coords append a column to the layout correctly", {
expect_equal(test$COORD, c(1, 2, 1))
})

test_that("parse_coord_expand parses correctly", {

p <- parse_coord_expand(FALSE)
expect_equal(p, rep(FALSE, 4))

p <- parse_coord_expand(c(FALSE, TRUE))
expect_equal(p, c(FALSE, TRUE, FALSE, TRUE))

p <- parse_coord_expand(c(top = FALSE, left = FALSE))
expect_equal(p, c(FALSE, TRUE, TRUE, FALSE))

# Dependencies might use `expand = 1`
p <- parse_coord_expand(c(1, 0))
expect_equal(p, c(TRUE, FALSE, TRUE, FALSE))

})

test_that("coord expand takes a vector", {

base <- ggplot() + lims(x = c(0, 10), y = c(0, 10))
Expand Down
Loading