Skip to content

Tweak polar distance #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Tweak polar distance #6226

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68592d2
add boosts to radius
teunbrand Dec 10, 2024
8190292
tweak test
teunbrand Dec 10, 2024
5e8b749
accept snapshots
teunbrand Dec 10, 2024
4cda87d
resolve merge conflict
teunbrand Jan 27, 2025
9d7ac15
add news bullet
teunbrand Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R/coord-polar.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ CoordPolar <- ggproto("CoordPolar", Coord,

is_free = function() TRUE,

distance = function(self, x, y, details) {
distance = function(self, x, y, details, boost = 0.75) {
arc <- self$start + c(0, 2 * pi)
dir <- self$direction
if (self$theta == "x") {
Expand All @@ -94,8 +94,8 @@ CoordPolar <- ggproto("CoordPolar", Coord,
r <- rescale(x, from = details$r.range)
theta <- theta_rescale_no_clip(y, details$theta.range, arc, dir)
}

dist_polar(r, theta)
# The ^boost boosts detailed munching when r is small
dist_polar(r^boost, theta)
},

backtransform_range = function(self, panel_params) {
Expand Down
6 changes: 3 additions & 3 deletions R/coord-radial.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ CoordRadial <- ggproto("CoordRadial", Coord,

is_free = function() TRUE,

distance = function(self, x, y, details) {
distance = function(self, x, y, details, boost = 0.75) {
arc <- details$arc %||% c(0, 2 * pi)
if (self$theta == "x") {
r <- rescale(y, from = details$r.range, to = self$inner_radius / 0.4)
Expand All @@ -129,8 +129,8 @@ CoordRadial <- ggproto("CoordRadial", Coord,
r <- rescale(x, from = details$r.range, to = self$inner_radius / 0.4)
theta <- theta_rescale_no_clip(y, details$theta.range, arc)
}

dist_polar(r, theta)
# The ^boost boosts detailed munching when r is small
dist_polar(r^boost, theta)
},

backtransform_range = function(self, panel_params) {
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/_snaps/coord-polar/bottom-half-circle-with-rotated-text.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading