Making copies of trained position scales #6286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I'm a fan of the method name - it feels very un-ggplot2 to invoke physical phenomena |
|
I'm happy to entertain alternatives. To offer a few: |
|
let's go with the first |
Merge branch 'main' into copy_scale # Conflicts: # tests/testthat/test-scales.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #3441.
Briefly, it adds a
freeze()method to viewscales, that makes a pre-populated, untrainable copy of a position scale.This is more of a extension development hook so it isn't meaningfully exposed to users.