Skip to content

🩹 Don't warn when fatten is absent #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

🩹 Don't warn when fatten is absent #6310

merged 1 commit into from
Feb 27, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR amends #6238.

Briefly: it prevents a bunch of false positive warnings about the fatten parameters.

In some details; lifecycle::is_present(params$fatten) was evaluated as TRUE when fatten was absent and params$fatten returns NULL. This caused a bunch of false-positive deprecation warnings in stats that has geom = "crossbar" or geom = "pointrange", like stat_summary_bin().

@teunbrand teunbrand changed the title Don't warn when fatten is absent 🩹 Don't warn when fatten is absent Jan 29, 2025
@thomasp85 thomasp85 self-requested a review February 25, 2025 09:49
thomasp85
thomasp85 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit e727e2b into tidyverse:main Feb 27, 2025
13 checks passed
@teunbrand teunbrand deleted the amend_6238 branch February 27, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teunbrand @thomasp85