Skip to content

Bump level of panel grid blanknness in theme_classic() #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Bump level of panel grid blanknness in theme_classic() #6321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc654a9
use grid parent element to invoke blank element
teunbrand Feb 5, 2025
f208661
Tweak bullet with related changes
teunbrand Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,11 @@
is setup once in total instead of once per group (@teunbrand, #5971)
* `facet_grid(space = "free")` can now be combined with `coord_fixed()`
(@teunbrand, #4584).
* `theme_classic()` now has black ticks and text instead of dark gray. In
addition, `theme_classic()`'s axis line end is `"square"` (@teunbrand, #5978).
* `theme_classic()` has the following changes (@teunbrand, #5978 & #6320):
* Axis ticks are now black (`ink`-coloured) instead of dark gray.
* Axis line ends are now `"square"`.
* The panel grid is now blank at the `panel.grid` hierarchy level instead of
the `panel.grid.major` and `panel.grid.minor` levels.
* {tibble} is now suggested instead of imported (@teunbrand, #5986)
* The ellipsis argument is now checked in `fortify()`, `get_alt_text()`,
`labs()` and several guides (@teunbrand, #3196).
Expand Down
5 changes: 2 additions & 3 deletions R/theme-defaults.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,9 +495,8 @@ theme_classic <- function(base_size = 11, base_family = "",
) %+replace%
theme(
# no background and no grid
panel.border = element_blank(),
panel.grid.major = element_blank(),
panel.grid.minor = element_blank(),
panel.border = element_blank(),
panel.grid = element_blank(),

# show axes
axis.text = element_text(size = rel(0.8)),
Expand Down
Loading