Skip to content

Stack divide zero #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Stack divide zero #6341

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f9b3fd
avoid dividing by zero
teunbrand Feb 19, 2025
c90b6a3
add news bullet
teunbrand Feb 19, 2025
524f139
Merge branch 'main' into stack_divide_zero
teunbrand Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# ggplot2 (development version)

* `position_fill()` avoids stacking observations of zero (@teunbrand, #6338)
* New parameters for `geom_label()` (@teunbrand and @steveharoz, #5365):
* The `linewidth` aesthetic is now applied and replaces the `label.size`
argument.
Expand Down
5 changes: 4 additions & 1 deletion R/position-stack.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,10 @@
heights <- c(0, cumsum(y))

if (fill) {
heights <- heights / abs(heights[length(heights)])
total <- abs(heights[length(heights)])
if (total > sqrt(.Machine$double.eps)) {
heights <- heights / total

Check warning on line 229 in R/position-stack.R

View check run for this annotation

Codecov / codecov/patch

R/position-stack.R#L227-L229 

Added lines #L227 - L229 were not covered by tests
}
}
# We need to preserve ymin/ymax order. If ymax is lower than ymin in input, it should remain that way
if (!is.null(df$ymin) && !is.null(df$ymax)) {
Expand Down
Loading