⚡ Skip replacing NAs during mapping when appropriate #6344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #5032.
Briefly, it skips the NA replacment step if there are no NAs present.
Moreover
vec_assign()is faster (and I presume more type stable) thanifelse().I think it is more of an 'empirical' determination than relying on some palette attribute as is proposed in the linked PR.
Benchmarking this PR, note 4 continuous scales (x, y, size, colour):
Created on 2025-02-24 with reprex v2.1.1
The same code on the main branch gives me:
Created on 2025-02-24 with reprex v2.1.1