Skip to content

geom_raster() fallback for non-linear Cartesian coordinates #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

geom_raster() fallback for non-linear Cartesian coordinates #6383

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc6598d
exclude non-linear Cartesian children
teunbrand Mar 27, 2025
94ce089
Merge branch 'main' into fix_6382
teunbrand May 6, 2025
7cd3faa
Merge branch 'main' into fix_6382
teunbrand May 19, 2025
a6fd43f
simplify case
teunbrand May 19, 2025
1c80441
use snapshot test
teunbrand May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/geom-raster.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ GeomRaster <- ggproto("GeomRaster", Geom,

draw_panel = function(self, data, panel_params, coord, interpolate = FALSE,
hjust = 0.5, vjust = 0.5) {
if (!inherits(coord, "CoordCartesian")) {
if (!inherits(coord, "CoordCartesian") || !coord$is_linear()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be enough to test coord$is_linear() and forget about the special case for CoordCartesian?

The message below also needs an update

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good points, I agree

cli::cli_inform(c(
"{.fn {snake_class(self)}} only works with {.fn coord_cartesian}.",
i = "Falling back to drawing as {.fn {snake_class(GeomRect)}}."
Expand Down