Skip to content

Only RHS-formula accepted as lambda function #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
+20 −1
Merged

Only RHS-formula accepted as lambda function #6385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90c6446
only cast RHS formula to function
teunbrand Mar 28, 2025
6d01b3c
add test
teunbrand Mar 28, 2025
9eb9310
don't cast `bquote()` to lambda functions
teunbrand May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/scale-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,5 +1454,6 @@ trans_support_nbreaks <- function(trans) {
}

allow_lambda <- function(x) {
if (is_formula(x)) as_function(x) else x
# we check the 'call' class to prevent interpreting `bquote()` calls as a function
if (is_formula(x, lhs = FALSE) && !inherits(x, "call")) as_function(x) else x
}
18 changes: 18 additions & 0 deletions tests/testthat/test-utilities.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,24 @@ test_that("expose/ignore_data() can round-trip a data.frame", {

})

test_that("allow_lambda converts the correct cases", {

f <- allow_lambda(function(x) x + 1)
expect_equal(f(1), 2)

f <- allow_lambda(~ .x + 1)
expect_equal(f(1), 2)

f <- allow_lambda("A")
expect_equal(f, "A")

f <- allow_lambda(expression(A))
expect_equal(f, expression(A))

f <- allow_lambda(bquote("foo"~"bar"))
expect_equal(f, call("~", "foo", "bar"))
})

test_that("summary method gives a nice summary", {
# This test isn't important enough to break anything on CRAN
skip_on_cran()
Expand Down