Simplify zeroGrob()
#6391
Merged
Simplify zeroGrob()
#6391
+28
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Apr 2, 2025
| zeroGrob <- function() .zeroGrob | ||
|
|
||
| .zeroGrob <- NULL | ||
| on_load(.zeroGrob <- add_class(nullGrob(), "zeroGrob")) |
Collaborator
Author
There was a problem hiding this comment.
The zeroGrob class is appended here, because inherits(x, "zeroGrob") is sometimes used instead of is.zero(). I expect the situation to be the same in extension packages.
teunbrand
commented
Apr 2, 2025
| #' | ||
| #' @keywords internal | ||
| #' @export | ||
| zeroGrob <- function() .zeroGrob |
Collaborator
Author
There was a problem hiding this comment.
I've not removed this function altogether because there is some optimisation value in only constructing the .zeroGrob object once per session instead of all over the place. Moreover, I expect it might be prevalent in extensions.
Merge branch 'main' into discard_zerogrob # Conflicts: # NAMESPACE # R/grob-null.R # R/utilities.R # man/stat_connect.Rd # tests/testthat/test-facet-strips.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to fix #6390.
Briefly, instead of implementing a full
<zeroGrob>class, we piggyback on thegrid::nullGrob().Simplification is the goal of this PR.