Skip to content

Conversation

@teunbrand
Copy link
Collaborator

This PR aims to fix #6393.

It takes the 'violent' path of deprecating the field.
We can also choose to delay deprecating the field.

@thomasp85
Copy link
Member

I'm slightly unsure why we need this. Yes, it "simplifies" the class definition, but on the other hand it also removes some self-documenting aspects of it.

Do you have other reasons for this beside "we can do without"?

@teunbrand
Copy link
Collaborator Author

The main reason I'd say is that it is a cause of confusion when learning how to build ggplot2 extensions because it isn't really clear what should go into optional_aes. It is better now that #6426 describes the field, but it remains somewhat redundant and befuddles a clear path for how to implement optional aesthetics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discourage use of optional_aes field

2 participants