Skip to content

Conversation

teunbrand
Copy link
Collaborator

This PR aims to clean up some fallout from releasing 3.5.2.

Briefly:

  • Cleans up NEWS.md (Release 3.5.2 #6403 (comment))
  • Adds element_geom(), element_polygon() and element_point() to is_theme_element(type) options.
  • Consistently use the new is_*() functions.
  • Convert remaining internal is.*() functions to is_*() functions.

thomasp85 and others added 30 commits April 22, 2024 11:50
Merge branch 'main' into rc/3.5.2

# Conflicts:
#	DESCRIPTION
#	NAMESPACE
#	R/aes.R
#	R/bin.R
#	R/coord-.R
#	R/coord-cartesian-.R
#	R/facet-.R
#	R/fortify.R
#	R/geom-.R
#	R/geom-defaults.R
#	R/geom-label.R
#	R/ggproto.R
#	R/guide-.R
#	R/guide-axis.R
#	R/guides-.R
#	R/layer.R
#	R/margins.R
#	R/plot-build.R
#	R/plot-construction.R
#	R/plot.R
#	R/position-.R
#	R/save.R
#	R/scale-.R
#	R/scale-colour.R
#	R/stat-.R
#	R/stat-ellipse.R
#	R/theme-current.R
#	R/theme-elements.R
#	R/theme.R
#	README.Rmd
#	cran-comments.md
#	man/coord_polar.Rd
#	man/element.Rd
#	man/get_geom_defaults.Rd
#	man/is_tests.Rd
#	man/stat_connect.Rd
#	man/stat_ellipse.Rd
#	revdep/README.md
#	revdep/cran.md
#	revdep/failures.md
#	revdep/problems.md
#	tests/testthat/_snaps/utilities-checks.md
#	tests/testthat/test-utilities-checks.R
@teunbrand
Copy link
Collaborator Author

Closing this in favour of #6432

@teunbrand teunbrand closed this Apr 16, 2025
teunbrand added a commit that referenced this pull request May 19, 2025
* rename `is.waiver()` to `is_waiver()`

* rename `is.zero()` to `is_zero()`

* rename `is.rel()` to `is_rel()`

* replace `is.formula()` with `rlang::is_formula()`

* rename `is.derived()` to `is_derived()`

* rename `is.sec_axis()` to `is_sec_axis()`

* rename `is.discrete()` to `is_discrete()`

* include novelty elements in `is_theme_element()`

* consistently use `is_theme_element()`

* catch an `is_zero()` case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants