Facet: gain draw_facet_panels method to draw grobs for each panel #6421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll get around to reviewing it at some point after discussing with Thomas a bit |
teunbrand
requested changes
Apr 22, 2025
R/facet-.R
Outdated
| draw_front = function(data, layout, x_scales, y_scales, theme, params) { | ||
| rep(list(zeroGrob()), vec_unique_count(layout$PANEL)) | ||
| }, | ||
| draw_facet_panels = function(self, panels, layout, x_scales, y_scales, |
There was a problem hiding this comment.
Is there a better self-descriptive name for this method that we could choose here? Something like draw_panel_content()? It is a bit confusing that there already is a draw_panels() method and I don't think 'facet panels' is doing any favours clearing up any distinction.
|
Thanks for reviewing—I’ve renamed the method accordingly. |
Co-authored-by: Teun van den Brand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6406
Following the advice of @teunbrand