Skip to content

guide_axis_theta: fix missing label for one unique key #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

guide_axis_theta: fix missing label for one unique key #6424

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
350721d
guide_axis_theta: fix missing label for one unique key
Yunuuuu Apr 14, 2025
55f1b71
rename the test result
Yunuuuu Apr 14, 2025
08d8932
simplify the test
Yunuuuu Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions R/guide-axis-theta.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ GuideAxisTheta <- ggproto(

# If the first and last positions are close together, we merge the
# labels of these positions
ends_apart <- (key$theta[n] - key$theta[1]) %% (2 * pi)
if (n > 0 && ends_apart < 0.05 && !is.null(key$.label)) {
if (n > 1L &&
(key$theta[n] - key$theta[1]) %% (2 * pi) < 0.05 &&
!is.null(key$.label)) {
if (is.expression(key$.label[[1]])) {
combined <- substitute(
paste(a, "/", b),
Expand Down
52 changes: 52 additions & 0 deletions tests/testthat/_snaps/guide-axis/guide-axis-theta-with-only-one-axis-key.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions tests/testthat/test-guide-axis.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,14 @@ test_that("guide_axis_theta sets relative angle", {
expect_doppelganger("guide_axis_theta with angle adapting to theta", p)
})

test_that("guide_axis_theta with only one axis key", {
p <- ggplot(data.frame(x = "a", y = 1:3), aes(x, y)) +
geom_point() +
coord_radial(start = 0, end = pi / 2, inner.radius = 0.5) +
guides(theta = guide_axis_theta(angle = 0))
expect_doppelganger("guide_axis_theta with only one axis key", p)
})

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a visual snapshot, we can get_guide_data(p, "theta") to test the representation of the guide. The rest of the plot can also be simplified by leaving out the guides() and the arguments to coord_radial().

test_that("guide_axis_theta can be used in cartesian coordinates", {

p <- ggplot(mtcars, aes(disp, mpg)) +
Expand Down