Simplify scale training #6443
Merged
Simplify scale training #6443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Apr 30, 2025
Comment on lines
+206
to
+207
| Discrete value supplied to a continuous scale. | ||
| i Example values: "A" and "E". |
There was a problem hiding this comment.
Arguably slightly worse, but if we want to improve this, this should happen in the scales package.
teunbrand
commented
Apr 30, 2025
Comment on lines
+1180
to
+1182
| if (length(x) == 0) { | ||
| return() | ||
| } |
There was a problem hiding this comment.
For consistency's sake early exit first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6184.
Briefly, the actual solution is already implemented in the scales package in r-lib/scales#481. We just adapt ggplot2 to this solution by abdicating responsibility to scales.