Skip to content

Prevent instantiating NULL palettes #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Prevent instantiating NULL palettes #6448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions R/theme.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,13 +545,14 @@
}

# Standardise spelling
elements <- replace_null(
elements,
palette.colour.discrete = elements$palette.color.discrete,
palette.colour.continuous = elements$palette.color.continuous
)
elements$palette.color.discrete <- NULL
elements$palette.color.continuous <- NULL
if ("palette.color.continuous" %in% names(elements)) {
elements["palette.colour.continuous"] <- elements["palette.color.continuous"]
elements[["palette.color.continuous"]] <- NULL

Check warning on line 550 in R/theme.R

View check run for this annotation

Codecov / codecov/patch

R/theme.R#L549-L550 

Added lines #L549 - L550 were not covered by tests
}
if ("palette.color.discrete" %in% names(elements)) {
elements["palette.colour.discrete"] <- elements["palette.color.discrete"]
elements[["palette.color.discrete"]] <- NULL

Check warning on line 554 in R/theme.R

View check run for this annotation

Codecov / codecov/patch

R/theme.R#L553-L554 

Added lines #L553 - L554 were not covered by tests
}

# Check for incompatible options
pals <- c("palette.colour.discrete", "palette.colour.continuous",
Expand Down