Update svglite-based snapshots #6453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
May 19, 2025
teunbrand
added a commit
that referenced
this pull request
May 19, 2025
* deal with NA/NULL breaks earlier * generalise `trans_support_nbreaks()` --> `support_nbreaks()` * early exit on zero-range limits * apply `n.breaks` regarless or whence breaks-function came * Throw `NA` breaks error in 1 place * omit outdated comment * include binned scales * approve pattern snapshots (re: #6453) * add news bullet
|
I've piggybacked this into #5974, so this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a few visual tests, we use a custom svglite writer instead of vdiffr's writer to incorporate patterns.
The latest release of svglite appears to write text slightly differently, which this PR updates.