Skip to content

Tiptoe around na.value #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Tiptoe around na.value #6500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20a7e6b
separate logic for complex structures
teunbrand Jun 11, 2025
c0d08e2
use `is_null`
teunbrand Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion R/scale-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,11 @@ ScaleDiscrete <- ggproto("ScaleDiscrete", Scale,
if (!is_null(pal_names)) {
# if pal is named, limit the pal by the names first,
# then limit the values by the pal
vec_slice(pal, is.na(match(pal_names, limits))) <- na_value
if (is.null(dim(pal))) {
pal[is.na(match(pal_names, limits))] <- na_value
} else {
vec_slice(pal, is.na(match(pal_names, limits))) <- na_value
}
pal <- vec_set_names(pal, NULL)
limits <- pal_names
}
Expand Down