Skip to content

Conversation

teunbrand
Copy link
Collaborator

This PR amends #6631.

I spotted this in the following test in the CI, where the warning from #6631 popped up:

test_that("stat_boxplot errors with missing x/y aesthetics", {
p <- ggplot(PlantGrowth) +
geom_boxplot()
expect_snapshot_error(ggplot_build(p))
})

Arguably, when you're missing the x and y aesthetic, getting the orientation right is a secondary problem and distracts from the missing aesthetic problem.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 6a447ba into tidyverse:main Sep 29, 2025
13 checks passed
@teunbrand teunbrand deleted the amend_6631 branch September 29, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants