Skip to content

Improve boundary handling #6684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Open

Improve boundary handling #6684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb65795
correct parenthesis
teunbrand Oct 7, 2025
b4f7daa
add contingent case
teunbrand Oct 7, 2025
af64a28
add news bullet
teunbrand Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Bug fixes

* Fixed bug where `stat_bin(boundary)` was ignored (#6682).
* Fixed regression where `draw_key_rect()` stopped using `fill` colours
(@mitchelloharawild, #6609).
* Fixed regression where `scale_{x,y}_*()` threw an error when an expression
Expand Down
7 changes: 6 additions & 1 deletion R/bin.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ bin_breaks_bins <- function(x_range, bins = 30, center = NULL,
} else {
width <- (x_range[2] - x_range[1]) / (bins - 1)
if (is.null(center)) {
boundary <- boundary %||% x_range[1] - width / 2
boundary <- boundary %||% (x_range[1] - width / 2)
}
# If `x_range` coincides with boundary we should
# use exact `bins` instead of `bins - 1` to prevent misalignments.
if (!is.null(boundary) && any(x_range %% width == boundary %% width)) {
width <- (x_range[2] - x_range[1]) / bins
}
}

Expand Down