Skip to content

Avoid scary implicit conversion from sexp to bool #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Avoid scary implicit conversion from sexp to bool #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/zip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

#include "rapidxml/rapidxml_print.h"

#include "cpp11/as.hpp"
#include "cpp11/function.hpp"
#include "cpp11/raws.hpp"
#include "cpp11/sexp.hpp"

std::string zip_buffer(const std::string& zip_path,
const std::string& file_path) {
Expand All @@ -19,7 +21,8 @@ std::string zip_buffer(const std::string& zip_path,
bool zip_has_file(const std::string& zip_path,
const std::string& file_path) {
cpp11::function zip_has_file = cpp11::package("readxl")["zip_has_file"];
return zip_has_file(zip_path, file_path);
cpp11::sexp out = zip_has_file(zip_path, file_path);
return cpp11::as_cpp<bool>(out);
}

std::string xml_print(std::string xml) {
Expand Down