fix: add topic_tools to the caret release script#212
Merged
Conversation
Signed-off-by: ISP akm <akm@isp.co.jp>
ymski
reviewed
Mar 28, 2025
Contributor
ymski
left a comment
ymski
left a comment
There was a problem hiding this comment.
Code review and testing was done and it looked fine.
I think it would be better to specify that we have added topic_tools to the release_script, as this PR description and title may cause misunderstanding.
xygyo77
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the following release scripts to incorporate the topic_tools package into caret.
This modification is also incorporated into v0.6.2 tags.
Related links
https://tier4.atlassian.net/browse/RT2-2211
#211
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.