chore: add /AGNOCAST_SRV_* to the default values for topic filters.#226
Merged
chore: add /AGNOCAST_SRV_* to the default values for topic filters.#226
Conversation
Signed-off-by: ISP akm <akm@isp.co.jp>
xygyo77
changed the title
ymski
approved these changes
Feb 9, 2026
Contributor
ymski
left a comment
ymski
left a comment
There was a problem hiding this comment.
This PR is related to tier4/caret_trace#322 (comment).
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In agnocast, service communication utilizes topics. Since caret's runtime measurement targets only topics, we want to avoid mixing in service-specific topics here.
Service topics in agnocast are prefixed with “/AGNOCAST_SRV_”. Therefore, we add this prefix to caret's default topic filter to permanently include it in the filtering scope.
Related links
https://tier4.atlassian.net/browse/SYSPERF-98?focusedCommentId=283587&sourceType=mention
Notes for reviewers
Confirmed only in a humble environment.
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.