-
Notifications
You must be signed in to change notification settings - Fork 135
docs: Add docs for tracking policy activity #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewdupre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small suggestions but I don't need to rereview - thanks
ctauchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @tianfeng92! I have a few comments in the code. One thing Pasan touched on was the overall structure of the document. I think it might be good to consider something simpler.
[h2] About policy activity logs
- overview of what this is, use case, etc.
[h2] Log structure / Data types
- a table log elements
[h2] Find unused policies
- a step-by-step procedure that explains how to complete this task
- I'm guessing it's 1) run this query 2) get all your policies 3) compare (would be good maybe to explain how to do it?
This represents all the same information have, but presents it in a way that's easier for users to find. Particularly the procedure for finding unused policies.
Co-authored-by: pasanw <[email protected]>
Co-authored-by: pasanw <[email protected]>
Co-authored-by: pasanw <[email protected]>
Co-authored-by: pasanw <[email protected]>
Co-authored-by: pasanw <[email protected]>
Co-authored-by: Christopher Tauchen <[email protected]>
pasanw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final comments, no need for me to re-review
Co-authored-by: pasanw <[email protected]>
ctauchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tianfeng92 Thanks for the changes, I think that reads well. One nit, then I'm happy to merge and leave for QA.
594b8e8 to
46f9e42
Compare
f970070 to
868a562
Compare

Product Version(s): Calico Enterprise v3.23-1
Issue: https://tigera.atlassian.net/browse/EV-4281
Link to docs preview: https://deploy-preview-2449--calico-docs-preview-next.netlify.app/calico-enterprise/next/observability/elastic/policy-activity
SME review:
DOCS review:
Additional information:
Merge checklist: