Skip to content

Conversation

@tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Jan 7, 2026

Product Version(s): Calico Enterprise v3.23-1

Issue: https://tigera.atlassian.net/browse/EV-4281

Link to docs preview: https://deploy-preview-2449--calico-docs-preview-next.netlify.app/calico-enterprise/next/observability/elastic/policy-activity

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@netlify
Copy link

netlify bot commented Jan 7, 2026

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 868a562
🔍 Latest deploy log https://app.netlify.com/projects/calico-docs-preview-next/deploys/6961388e38184c000841d65e
😎 Deploy Preview https://deploy-preview-2449--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 7, 2026

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 868a562
🔍 Latest deploy log https://app.netlify.com/projects/tigera/deploys/6961388eaf51b200081a19f0
😎 Deploy Preview https://deploy-preview-2449--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🟢 up 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@tianfeng92 tianfeng92 marked this pull request as ready for review January 7, 2026 19:40
@tianfeng92 tianfeng92 requested a review from a team as a code owner January 7, 2026 19:40
Copy link
Member

@matthewdupre matthewdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions but I don't need to rereview - thanks

@tianfeng92 tianfeng92 requested a review from pasanw January 8, 2026 00:04
Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @tianfeng92! I have a few comments in the code. One thing Pasan touched on was the overall structure of the document. I think it might be good to consider something simpler.

[h2] About policy activity logs

  • overview of what this is, use case, etc.

[h2] Log structure / Data types

  • a table log elements

[h2] Find unused policies

  • a step-by-step procedure that explains how to complete this task
  • I'm guessing it's 1) run this query 2) get all your policies 3) compare (would be good maybe to explain how to do it?

This represents all the same information have, but presents it in a way that's easier for users to find. Particularly the procedure for finding unused policies.

@tianfeng92 tianfeng92 requested a review from ctauchen January 8, 2026 19:14
@tianfeng92 tianfeng92 requested a review from pasanw January 8, 2026 19:28
Copy link
Contributor

@pasanw pasanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments, no need for me to re-review

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianfeng92 Thanks for the changes, I think that reads well. One nit, then I'm happy to merge and leave for QA.

@tianfeng92 tianfeng92 force-pushed the EV-4281-policy-activity branch from 594b8e8 to 46f9e42 Compare January 9, 2026 17:02
@tianfeng92 tianfeng92 force-pushed the EV-4281-policy-activity branch from f970070 to 868a562 Compare January 9, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants