-
Notifications
You must be signed in to change notification settings - Fork 138
DOCS-2549: Update CC L7 logs to use deployment-patch method #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -40,32 +40,36 @@ L7 logs are visible in the web console, service graph, in the HTTP tab. | |||||||||||||||
| **Not supported** | ||||||||||||||||
| - GKE | ||||||||||||||||
|
|
||||||||||||||||
| **Limitations** | ||||||||||||||||
| ### Limitations | ||||||||||||||||
|
|
||||||||||||||||
| - L7 log collection is not supported for host-networked client pods. | ||||||||||||||||
| - When selecting and deselecting traffic for L7 log collection, active connections may be disrupted. | ||||||||||||||||
| * L7 log collection is not compatible with a service mesh such as Istio. | ||||||||||||||||
| * L7 log collection is not supported for host-networked client pods. | ||||||||||||||||
| * L7 log collection is supported only on Kubernetes 1.29 and later. | ||||||||||||||||
|
|
||||||||||||||||
| {/*TODO-XREFS-CC | ||||||||||||||||
| Note removed for CC | ||||||||||||||||
| */} | ||||||||||||||||
| :::important | ||||||||||||||||
|
|
||||||||||||||||
| ## How to | ||||||||||||||||
| When you enable L7 log collection for a deployment, all of that deployment's pods will restart. | ||||||||||||||||
| Selecting and deselecting traffic for L7 log collection may result in disruptions for active connections. | ||||||||||||||||
|
|
||||||||||||||||
| - [Configure Felix for log data collection](#configure-felix-for-log-data-collection) | ||||||||||||||||
| - [Configure L7 logs](#configure-l7-logs) | ||||||||||||||||
| - [View L7 logs in the web console](#view-l7-logs-in-manager-ui) | ||||||||||||||||
| ::: | ||||||||||||||||
|
|
||||||||||||||||
| :::note | ||||||||||||||||
|
|
||||||||||||||||
| L7 logs require a minimum of 1 additional GB of log storage per node, per one-day retention period. Adjust your [Log Storage](../../../operations/logstorage/adjust-log-storage-size.mdx) before you start tasks in the next section. | ||||||||||||||||
|
||||||||||||||||
| L7 logs require a minimum of 1 additional GB of log storage per node, per one-day retention period. Adjust your [Log Storage](../../../operations/logstorage/adjust-log-storage-size.mdx) before you start tasks in the next section. | |
| L7 logs require a minimum of 1 additional GB of log storage per node, per one-day retention period. Adjust your [Log Storage](../../../operations/) before you start tasks in the next section. |
Copilot
AI
Mar 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanatory sentence starts with lowercase "without"/"if" and reads like a run-on sentence. Please capitalize and split into clearer sentences (and consider calling out explicitly that subsequent commands need -n <namespace> if not using default).
| without the `-n <namespace>` flag, it is going to be installed in the `default` namespace. if you wish to install in a different namespace, specify the `-n <namespace>` flag on all other commands in this tutorial from this point on. | |
| Without the `-n <namespace>` flag, this command installs the demo in the `default` namespace. If you want to use a different namespace, add the `-n <namespace>` flag to this command and to all subsequent `kubectl` commands in this tutorial. |
Copilot
AI
Mar 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quickstart notes using -n <namespace> when not installing into default, but the kubectl patch deployment frontend ... example doesn’t include a namespace. Please add -n <namespace> (or explicitly state the command assumes default) to prevent users patching the wrong deployment or hitting "not found" errors.
Copilot
AI
Mar 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ordered list explaining the patch is hard to read and has grammar issues (e.g., "ensures pods ... has" and lowercase sentence starts). Consider rewriting to refer to the Deployment's pod template (singular) and capitalizing the list items so the explanation is unambiguous.
| The above command applies the following patch: | |
| 1. ensures pods in your `frontend` deployment pod template spec has the label `applicationlayer.projectcalico.org/sidecar: true` | |
| 1. ensures pods in your `frontend` deployment pod template spec has the following annotations: | |
| - `applicationlayer.projectcalico.org/logging: Enabled` | |
| The above command patches the `frontend` Deployment's pod template to: | |
| 1. Add the label `applicationlayer.projectcalico.org/sidecar: true`. | |
| 1. Add the annotation `applicationlayer.projectcalico.org/logging: Enabled`. |
Copilot
AI
Mar 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the demo is installed into a non-default namespace, kubectl rollout status deployment frontend also needs -n <namespace> to match the earlier guidance. Please update the example (or state it assumes default).
Copilot
AI
Mar 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The disable command kubectl patch deployment frontend --type='json' ... also omits -n <namespace>, even though the preceding note says to use it for non-default installs. Please include the namespace flag here as well (or explicitly state these commands assume the default namespace).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading is still using bold text (
**Not supported**) rather than a Markdown heading, which is inconsistent with the rest of the page after the heading-hierarchy updates. Consider converting it to a proper heading (for example### Not supported) so it appears in the TOC and has consistent styling.