expose logLevel for apiserver containers#3652
Merged
rene-dekker merged 3 commits intotigera:masterfrom Dec 19, 2024
Merged
Conversation
ti-afra
force-pushed
the
log-level
branch
5 times, most recently
from
33af101 to
b387d07
Compare
api/v1/apiserver_types.go
Outdated
| // +optional | ||
| Resources *v1.ResourceRequirements `json:"resources,omitempty"` | ||
|
|
||
| // +kubebuilder:validation:Enum=fatal;error;warn;info;debug;trace |
Member
There was a problem hiding this comment.
These should be capitalized - e.g., Fatal, Error, etc.
This just matches k8s API conventions for enum types
gomega Expect was not able to compare correctly the dex policies and would fail when running in "Run" mode but pass when running in "Debug" mode. It was also passing when we print the values before the Expect().To() call. To fix this, we convert the larger and nested struct to String and compare the string values.
caseydavenport
approved these changes
Dec 18, 2024
ti-afra
added a commit
to ti-afra/operator
that referenced
this pull request
Dec 19, 2024
* expose logLevel in apiserver manifest for its containers * fix unstable gomega match for large nested dex policies gomega Expect was not able to compare correctly the dex policies and would fail when running in "Run" mode but pass when running in "Debug" mode. It was also passing when we print the values before the Expect().To() call. To fix this, we convert the larger and nested struct to String and compare the string values. * update crd: securityeventwebhooks
rene-dekker
pushed a commit
that referenced
this pull request
Dec 20, 2024
* expose logLevel in apiserver manifest for its containers * fix unstable gomega match for large nested dex policies gomega Expect was not able to compare correctly the dex policies and would fail when running in "Run" mode but pass when running in "Debug" mode. It was also passing when we print the values before the Expect().To() call. To fix this, we convert the larger and nested struct to String and compare the string values. * update crd: securityeventwebhooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.