Skip to content

Fix Dex policy test flake#3673

Merged
marvin-tigera merged 1 commit intotigera:masterfrom
pasanw:fix-dex-pol-flake
Dec 20, 2024
Merged

Fix Dex policy test flake#3673
marvin-tigera merged 1 commit intotigera:masterfrom
pasanw:fix-dex-pol-flake

Conversation

@pasanw
Copy link
Contributor

@pasanw pasanw commented Dec 20, 2024

Description

After some refactors to policy rendering in #3636, the Dex component inserts rules into rendered policy based on a map iteration. Since map iteration order is random, this was causing flakes when comparing the rendered policy to the expected policy. This PR adjusts the expectation to support differences in ordering.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker
Copy link
Member

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants