Don't create resources in terminating Namespaces#3791
Merged
caseydavenport merged 4 commits intotigera:masterfrom Feb 26, 2025
Merged
Don't create resources in terminating Namespaces#3791caseydavenport merged 4 commits intotigera:masterfrom
caseydavenport merged 4 commits intotigera:masterfrom
Conversation
caseydavenport
force-pushed
the
casey-fix-uninstall
branch
from
3f89bfa to
a86c0be
Compare
caseydavenport
changed the title
tmjd
reviewed
Feb 26, 2025
Member
tmjd
left a comment
tmjd
left a comment
There was a problem hiding this comment.
For all the changes in the in the component_test I don't see any test for this new behavior. Could you add one?
tmjd
approved these changes
Feb 26, 2025
caseydavenport
added a commit
to caseydavenport/operator
that referenced
this pull request
Feb 26, 2025
* Don't install resources into terminating Namespaces * Fix tests * Add UT * make gen-versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some cases, the operator can attempt to create new resources within a
terminating Namespace with fianlizers set on objects within. If this happens, an error will occur, which
prevents reaching the NodeComponent who is responsible for removing
those finalizers. As a result, we deadlock.
We should never be installing resources into Namespaces that are being torn down, since it will never succeed!
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.