Render CSR roles when NonClusterHost feature is enabled#3834
Merged
rene-dekker merged 1 commit intotigera:masterfrom Mar 25, 2025
Merged
Render CSR roles when NonClusterHost feature is enabled#3834rene-dekker merged 1 commit intotigera:masterfrom
rene-dekker merged 1 commit intotigera:masterfrom
Conversation
This change adds the NonClusterHost resource check to render CSR roles for the CSR controller. It is required to validate and sign CSRs generated from non-cluster hosts.
rene-dekker
approved these changes
Mar 25, 2025
hjiawei
added a commit
to hjiawei/operator
that referenced
this pull request
Mar 25, 2025
This change adds the NonClusterHost resource check to render CSR roles for the CSR controller. It is required to validate and sign CSRs generated from non-cluster hosts.
5 tasks
rene-dekker
pushed a commit
that referenced
this pull request
Mar 26, 2025
* Support non-cluster host scaling with Typha (#3817) * Support non-cluster host scaling with Typha * Create Kubernetes Clientset from config only once * Allow certificate signing request from non-cluster hosts * Add and fix unit tests * Create a separate key pair for non-cluster host Typha * Start the non-cluster host Typha autoscaler for enterprise only * Perform SubjectAccessReview for non-cluster host CSRs * Start Typha auto-scaler when NonClusterHost resource exists * Add a 10 second timeout when performing access reviews * Rerun make generate * Render CSR roles when NonClusterHost feature is enabled (#3834) This change adds the NonClusterHost resource check to render CSR roles for the CSR controller. It is required to validate and sign CSRs generated from non-cluster hosts. * FV test with Calico OSS release-v3.30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the NonClusterHost resource check to render CSR roles for the CSR controller. It is required to validate and sign CSRs generated from non-cluster hosts.
Should be part of #3817.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.