Rename tigera-guardian components to guardian#3845
Merged
Brian-McM merged 1 commit intotigera:masterfrom Apr 2, 2025
Merged
Conversation
rene-dekker
reviewed
Mar 28, 2025
| GuardianContainerName = "tigera-guardian" | ||
| GuardianServiceName = "guardian" | ||
| GuardianVolumeName = "guardian-certs" | ||
| GuardianSecretName = "tigera-managed-cluster-connection" |
Member
There was a problem hiding this comment.
Any reason this can't be guardian-managed-cluster-connection or calico-managed-cluster-connection or just managed-cluster-connection?
Contributor
Author
There was a problem hiding this comment.
We don't create this secret, it's done in CC / the management cluster.
Member
There was a problem hiding this comment.
Not asking you to do this now, but seems like it should probably be a SecretRef on the ManagedClusterConnection resource rather than hard-coded.
Member
|
@rene-dekker @Brian-McM is there something currently blocking this one? |
rene-dekker
approved these changes
Apr 2, 2025
Since tigera-guardian has been moved to the calico-system namespace we've decided to remove the tigera prefix since it's redundant The container name needs to stay the same so the overrides API doesn't break.
Brian-McM
force-pushed
the
bm-rename-tigera-guardian-to-guardian
branch
from
7f78ab8 to
0c0e419
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since tigera-guardian has been moved to the calico-system namespace we've decided to remove the tigera prefix since it's redundant
The container name needs to stay the same so the overrides API doesn't break.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.Release Note