Skip to content

[Cherry-pick][v1.37] Add rbac to delete secrets (#3870)#3873

Merged
asincu merged 1 commit intotigera:release-v1.37from
asincu:cherry_pick_add_rbac_secrets
Apr 8, 2025
Merged

[Cherry-pick][v1.37] Add rbac to delete secrets (#3870)#3873
asincu merged 1 commit intotigera:release-v1.37from
asincu:cherry_pick_add_rbac_secrets

Conversation

@asincu
Copy link
Copy Markdown
Contributor

@asincu asincu commented Apr 8, 2025

  • Add rbac to delete secrets for external controller

When connecting a managed cluster to a management single tenant cluster, es-kube-controllers are responsible for copying the voltron linseed certificate via the tunnel. Before this operation, es kube controllers will first reconcile users. Any failure in reconciling users will lead to the certificate not being copied over. The first step in user reconciliation is to delete secret for decommisioned users or components, like curator. A failure because of missing RBAC will result the certificate not copied over, namespaces for fluentD, commpliance and intrusion controller not being created in the managed cluster. Single tenant management clusters with external elasticsearch are configured using external elasticsearch controller and rendered.

  • Fix! Update CRDs

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

* Add rbac to delete secrets for external controller

When connecting a managed cluster to a management single tenant cluster,
es-kube-controllers are responsible for copying the voltron linseed
certificate via the tunnel. Before this operation, es kube controllers
will first reconcile users. Any failure in reconciling users will lead
to the certificate not being copied over. The first step in user
reconciliation is to delete secret for decommisioned users or
components, like curator. A failure because of missing RBAC will result
the certificate not copied over, namespaces for fluentD, commpliance and
intrusion controller not being created in the managed cluster. Single
tenant management clusters with external elasticsearch are configured
using external elasticsearch controller and rendered.

* Fix! Update CRDs
Copy link
Copy Markdown
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asincu asincu merged commit 0bd845f into tigera:release-v1.37 Apr 8, 2025
2 checks passed
@asincu asincu deleted the cherry_pick_add_rbac_secrets branch April 8, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants