Add DATAPLANE env var to dikastes in l7-log-collector #4352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dikastes container in the l7-log-collector daemonset was missing the DATAPLANE environment variable, causing it to default to iptables even when nftables mode is configured. This aligns the l7-log-collector behavior with l7-admission-controller and egress-gateway, which already set DATAPLANE based on Installation spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix: The dikastes container in l7-log-collector daemonset was missing the DATAPLANE env var, causing it to default to iptables regardless of Installation spec.
This change adds the DATAPLANE env var to dikastes, using the same logic as l7-admission-controller and egress-gateway.
Testing:
Components affected: applicationlayer render
Release Note
For PR author
make gen-filesmake gen-versions